Skip to content

feat: support displaying beta tag in left nav item #747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 6, 2021
Merged

feat: support displaying beta tag in left nav item #747

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a5510fc
feat: support displaying beta tag in left nav item
arjunlalb Apr 6, 2021
ac7c09f
fix: remove resizing and increase width
arjunlalb Apr 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion projects/components/src/beta-tag/beta-tag.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,13 @@ import { Color } from '@hypertrace/common';
selector: 'ht-beta-tag',
changeDetection: ChangeDetectionStrategy.OnPush,
template: `
<ht-label-tag label="Beta" backgroundColor="${Color.Purple2}" labelColor="${Color.Purple5}"></ht-label-tag>
<ht-label-tag
htTooltip="Beta Feature"
class="beta-tag"
label="Beta"
backgroundColor="${Color.Purple2}"
labelColor="${Color.Purple5}"
></ht-label-tag>
`
})
export class BetaTagComponent {}
3 changes: 2 additions & 1 deletion projects/components/src/beta-tag/beta-tag.module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
import { NgModule } from '@angular/core';
import { LabelTagModule } from '../label-tag/label-tag.module';
import { TooltipModule } from '../tooltip/tooltip.module';
import { BetaTagComponent } from './beta-tag.component';

@NgModule({
declarations: [BetaTagComponent],
imports: [LabelTagModule],
imports: [LabelTagModule, TooltipModule],
exports: [BetaTagComponent]
})
export class BetaTagModule {}
5 changes: 5 additions & 0 deletions projects/components/src/navigation/nav-item/nav-item.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,11 @@
margin-left: 14px;
display: flex;
flex-direction: row;
align-items: center;

.beta {
margin-left: 8px;
}
}

.icon {
Expand Down
1 change: 1 addition & 0 deletions projects/components/src/navigation/nav-item/nav-item.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ import { NavItemLinkConfig } from '../navigation-list.component';
<span *ngIf="featureState === '${FeatureState.Preview}'" class="soon-container">
<span class="soon">SOON</span>
</span>
<ht-beta-tag *ngIf="config.isBeta" class="beta"></ht-beta-tag>
</div>
</div>
`
Expand Down
2 changes: 2 additions & 0 deletions projects/components/src/navigation/navigation-list.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,4 +85,6 @@

.expanded {
width: 220px;
overflow-x: hidden;
resize: horizontal;
Copy link
Contributor

@aaron-steinfeld aaron-steinfeld Apr 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want dynamic resize on the left nav? Since the widths are known ahead of time, we should have already sized appropriately (and I'm curious how the app responds to this changing size)

Copy link
Contributor Author

@arjunlalb arjunlalb Apr 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

}
1 change: 1 addition & 0 deletions projects/components/src/navigation/navigation-list.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@ export interface NavItemLinkConfig {
matchPaths: string[]; // For now, default path is index 0
features?: string[];
replaceCurrentHistory?: boolean;
isBeta?: boolean;
}

export type FooterItemConfig = FooterItemLinkConfig;
Expand Down