feat: Adding hover behaviour on select components #732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #732 +/- ##
=======================================
Coverage 85.20% 85.20%
=======================================
Files 786 786
Lines 16096 16097 +1
Branches 2003 2003
=======================================
+ Hits 13714 13715 +1
Misses 2349 2349
Partials 33 33
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
|
@itssharmasandeep Could you also add screenshots/screen recording of the behaviour? |
arjunlalb
reviewed
Mar 31, 2021
| *ngSwitchCase="'${SelectTriggerDisplayMode.Icon}'" | ||
| class="trigger-content icon-only" | ||
| [ngClass]="this.selected !== undefined ? 'selected' : ''" | ||
| [ngClass]="[this.selected !== undefined ? 'selected' : '', this.popoverOpen ? 'open' : '']" |
Contributor
There was a problem hiding this comment.
may be we should make this an object for better readability
"{ selected: this.selected !== undefined, open: this.popoverOpen}"
arjunlalb
previously approved these changes
Mar 31, 2021
| align-items: center; | ||
|
|
||
| &.open { | ||
| background-color: transparent; |
Contributor
There was a problem hiding this comment.
Is this doing anything or is it overridden by line 124 (indentation may be throwing me off here)
This comment has been minimized.
This comment has been minimized.
aaron-steinfeld
approved these changes
Mar 31, 2021
arjunlalb
approved these changes
Mar 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds hover and pressed behaviour on select, multi-select and menu-dropdown buttons
Testing
Tested locally
Screenshot for multi-select pressed
Checklist: