Skip to content

fix: Unable to click topology #731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 5, 2021
Merged

fix: Unable to click topology #731

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
45db32d
fix: Unable to click topology
Mar 30, 2021
d31e080
Merge branch 'main' of github.com:hypertrace/hypertrace-ui into Unabl…
Mar 31, 2021
0866634
fix: running lintern
Mar 31, 2021
3249de7
fix: modify bounding element
Apr 1, 2021
39792cf
fix: fixing lint
Apr 1, 2021
5d01a0e
fix: fixing lintern
Apr 1, 2021
e89deec
fix: refactoring of popover positioning
Apr 2, 2021
2dfb578
fix: refactoring of popover positioning
Apr 2, 2021
5aadb52
Merge branch 'main' of github.com:hypertrace/hypertrace-ui into Unabl…
Apr 2, 2021
1329f52
Merge branch 'main' of github.com:hypertrace/hypertrace-ui into Unabl…
Apr 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...bservability/src/shared/components/topology/renderers/tooltip/topology-tooltip-popover.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import {
PopoverBackdrop,
PopoverPositionType,
PopoverRef,
PopoverRelativePositionLocation,
PopoverService
} from '@hypertrace/components';
import { BehaviorSubject, merge, Observable, ReplaySubject, Subject } from 'rxjs';
Expand Down Expand Up @@ -86,9 +85,10 @@ export class TopologyTooltipPopover implements TopologyTooltip {
}

popover.updatePositionStrategy({
type: PopoverPositionType.Relative,
locationPreferences: [PopoverRelativePositionLocation.InsideTopLeft],
origin: this.container
type: PopoverPositionType.FollowMouse,
boundingElement: this.container.nativeElement,
offsetX: 50,
offsetY: 30
});

return popover;
Expand Down