Skip to content

Summary list component #706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jake-bassett merged 8 commits into from
Mar 22, 2021
Merged

Summary list component #706

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
983f8bf
feat: summary list component
jake-bassett Mar 18, 2021
67ca901
Merge branch 'main' of github.com:hypertrace/hypertrace-ui into summa…
jake-bassett Mar 19, 2021
472f652
fix: remove mock inputs
jake-bassett Mar 19, 2021
c5f9c38
Merge branch 'main' of github.com:hypertrace/hypertrace-ui into summa…
jake-bassett Mar 22, 2021
5ac7f1a
feat: startCase is smarter than I thought
jake-bassett Mar 22, 2021
f6e778d
feat: add test
jake-bassett Mar 22, 2021
1f94365
feat: fix test more betterer
jake-bassett Mar 22, 2021
843d189
Merge branch 'main' into summary-list-component
jake-bassett Mar 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion projects/components/src/summary-list/summary-list.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export class SummaryListComponent {
public items?: SummaryItem[] = [];

public getFormattedLabel(item: SummaryItem): string {
return startCase(item.label.trim().replace('-', ' ').replace('_', ' ').toLowerCase());
return startCase(item.label.trim().toLowerCase());
Copy link
Contributor

@aaron-steinfeld aaron-steinfeld Mar 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trim is definitely still taken care of by startCase, the most intelligent of all cases. lower case may not be though.

}

public getValuesArray(item: SummaryItem): PrimitiveValue[] {
Expand Down