-
Notifications
You must be signed in to change notification settings - Fork 11
Summary list component #706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
983f8bf
feat: summary list component
jake-bassett 67ca901
Merge branch 'main' of github.com:hypertrace/hypertrace-ui into summa…
jake-bassett 472f652
fix: remove mock inputs
jake-bassett c5f9c38
Merge branch 'main' of github.com:hypertrace/hypertrace-ui into summa…
jake-bassett 5ac7f1a
feat: startCase is smarter than I thought
jake-bassett f6e778d
feat: add test
jake-bassett 1f94365
feat: fix test more betterer
jake-bassett 843d189
Merge branch 'main' into summary-list-component
jake-bassett File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
32 changes: 32 additions & 0 deletions
32
projects/components/src/summary-list/summary-list.component.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| import { SummaryListComponent } from '@hypertrace/components'; | ||
| import { createComponentFactory, Spectator } from '@ngneat/spectator/jest'; | ||
|
|
||
| describe('Summary List component', () => { | ||
| let spectator: Spectator<SummaryListComponent>; | ||
|
|
||
| const createComponent = createComponentFactory({ | ||
| component: SummaryListComponent, | ||
| shallow: true, | ||
| declarations: [] | ||
| }); | ||
|
|
||
| beforeEach(() => { | ||
| spectator = createComponent(); | ||
| }); | ||
|
|
||
| test('formats label', () => { | ||
| expect(spectator.component.getFormattedLabel('TEST_UNDERSCORE')).toEqual('Test Underscore'); | ||
| expect(spectator.component.getFormattedLabel('TEST-DASH')).toEqual('Test Dash'); | ||
| expect(spectator.component.getFormattedLabel('Test_mixed-LABEL')).toEqual('Test Mixed Label'); | ||
| expect(spectator.component.getFormattedLabel('test MORE')).toEqual('Test More'); | ||
| }); | ||
|
|
||
| test('gets value array', () => { | ||
| expect(spectator.component.getValuesArray(1)).toEqual([1]); | ||
| expect(spectator.component.getValuesArray([1])).toEqual([1]); | ||
| expect(spectator.component.getValuesArray('two')).toEqual(['two']); | ||
| expect(spectator.component.getValuesArray(['two', 'three'])).toEqual(['two', 'three']); | ||
| expect(spectator.component.getValuesArray(true)).toEqual([true]); | ||
| expect(spectator.component.getValuesArray([true, false])).toEqual([true, false]); | ||
| }); | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For a component with inputs and ouputs, using a hostfactory allows you to provide inputs and then verify it rendered correctly. This test only verifies the logic directly rather than for a given set of inputs it renders the html we want - that's what we're generally looking for in a component's tests - the functions are implementation details.