Skip to content

Conversation

@anandtiwary
Copy link
Contributor

@anandtiwary anandtiwary commented Feb 26, 2021

Description

Please include a summary of the change, motivation and context.
feat: Add row parser

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@codecov
Copy link

codecov bot commented Feb 26, 2021

Codecov Report

Merging #644 (2137836) into main (706d1c5) will decrease coverage by 0.00%.
The diff coverage is 72.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #644      +/-   ##
==========================================
- Coverage   85.20%   85.20%   -0.01%     
==========================================
  Files         777      777              
  Lines       16010    16017       +7     
  Branches     2062     2066       +4     
==========================================
+ Hits        13642    13647       +5     
- Misses       2334     2335       +1     
- Partials       34       35       +1     
Impacted Files Coverage Δ
...ble/cells/data-parsers/table-cell-string-parser.ts 71.42% <72.72%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 706d1c5...2137836. Read the comment docs.

@github-actions

This comment has been minimized.

@anandtiwary anandtiwary changed the base branch from add-explore-parser to main February 26, 2021 23:06
@anandtiwary anandtiwary marked this pull request as ready for review February 26, 2021 23:11
@anandtiwary anandtiwary requested a review from a team as a code owner February 26, 2021 23:11
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@anandtiwary anandtiwary merged commit 5fdec57 into main Mar 1, 2021
@anandtiwary anandtiwary deleted the add-row-parser branch March 1, 2021 23:54
@github-actions
Copy link

github-actions bot commented Mar 1, 2021

Unit Test Results

    4 files  ±0  241 suites  ±0   15m 39s ⏱️ +39s
866 tests ±0  866 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
870 runs  ±0  870 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 5fdec57. ± Comparison against base commit 706d1c5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants