feat: additional dependencies for time agnostic apis #612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #612 +/- ##
=======================================
Coverage 85.17% 85.18%
=======================================
Files 770 770
Lines 15905 15905
Branches 2048 2048
=======================================
+ Hits 13547 13548 +1
+ Misses 2324 2323 -1
Partials 34 34
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
anandtiwary
reviewed
Feb 18, 2021
| return cellData; | ||
| case 'object': | ||
| return cellData === null ? undefined : cellData.value; | ||
| return cellData === null ? undefined : cellData.value === null ? undefined : cellData.value; |
Contributor
There was a problem hiding this comment.
nit: cellData?.value ?? undefined
anandtiwary
reviewed
Feb 18, 2021
projects/observability/src/shared/components/entity-renderer/entity-renderer.component.ts
Show resolved
Hide resolved
| filters: [new GraphQlEntityFilter(request.id, request.entityType)] | ||
| filters: [new GraphQlEntityFilter(request.id, request.entityType)], | ||
| // If querying for a single API, then always want to includeInactive | ||
| includeInactive: request.entityType === ObservabilityEntityType.Api |
Contributor
There was a problem hiding this comment.
This would apply always right? Even if we disabled this functionality elsewhere
Contributor
Author
There was a problem hiding this comment.
Hmm. Good point. It would. Not sure how to feature flag this cleanly. Open to suggestions.
This comment has been minimized.
This comment has been minimized.
aaron-steinfeld
approved these changes
Feb 19, 2021
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some additional changes for Time Agnostic APIs. This fixes an issue with drilling into an API that is fetched in a list using
includeInactive. We now include that property whenever querying for a single API. The second change here is to display null data correctly.