feat: time agnostic APIs

projects/distributed-tracing/src/public-api.ts

@@ -20,7 +20,7 @@ export * from './shared/dashboard/data/graphql/filter/graphql-filter-data-source
 export * from './shared/dashboard/data/graphql/filter/graphql-filter-data-source.model';
 export * from './shared/dashboard/data/graphql/graphql-table-control-options-data-source.model';
 export * from './shared/dashboard/data/graphql/graphql-data-source.model';
-export * from './shared/dashboard/data/graphql/graphql-options-data-source.model';
+export * from './shared/dashboard/data/graphql/graphql-table-control-options-data-source.model';
 export * from './shared/dashboard/data/graphql/graphql-query-event.service';
 export * from './shared/dashboard/data/graphql/graphql-data-source.module';
 export * from './shared/dashboard/data/graphql/specifiers/attribute-specification.model';

projects/distributed-tracing/src/shared/components/table/data-cell/metric/metric-table-cell-parser.ts

@@ -5,14 +5,14 @@ import { TracingTableCellType } from '../../tracing-table-cell-type';
 @TableCellParser({
   type: TracingTableCellType.Metric
 })
-export class MetricTableCellParser extends TableCellParserBase<number, number | null, number | null> {
-  public parseValue(cellData: CellData): number | null {
+export class MetricTableCellParser extends TableCellParserBase<number, CellValue, CellValue> {
+  public parseValue(cellData: CellData): CellValue {
     const extractedValue = this.extractValue(cellData);
 
-    return extractedValue === null ? extractedValue : Math.round(this.extractValue(cellData)!);
+    return extractedValue === undefined ? extractedValue : Math.round(extractedValue);
   }
 
-  public parseFilterValue(cellData: number): number | null {
+  public parseFilterValue(cellData: number): CellValue {
     return this.parseValue(cellData);
   }
 
@@ -21,12 +21,12 @@ export class MetricTableCellParser extends TableCellParserBase<number, number |
   }
 
   // tslint:disable-next-line:no-null-undefined-union
-  private extractValue(cellData: CellData): number | undefined | null {
+  private extractValue(cellData: CellData): CellValue {
     switch (typeof cellData) {
       case 'number':
         return cellData;
       case 'object':
-        return cellData.value;
+        return cellData === null ? undefined : cellData.value;
       default:
         return undefined;
     }
@@ -37,11 +37,12 @@ export class MetricTableCellParser extends TableCellParserBase<number, number |
       case 'number':
         return undefined;
       case 'object':
-        return cellData.units;
+        return cellData === null ? undefined : cellData.units;
       default:
         return undefined;
     }
   }
 }
 
-type CellData = number | Partial<MetricAggregation>;
+type CellData = number | null | Partial<MetricAggregation>;
+type CellValue = number | undefined;

projects/distributed-tracing/src/shared/components/table/data-cell/metric/metric-table-cell-renderer.component.ts

@@ -25,7 +25,7 @@ import { TracingTableCellType } from '../../tracing-table-cell-type';
       <!-- This displays as "<value> <unit>", e.g. 120 ms -->
       <span
         >{{ this.value | htDisplayNumber: this.formatter }}
-        <span *ngIf="this.value !== null && this.units">{{ this.units }}</span></span
+        <span *ngIf="this.value !== undefined && this.units">{{ this.units }}</span></span
       >
     </div>
   `