-
Notifications
You must be signed in to change notification settings - Fork 11
feat: adding sheet ref #536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@aaron-steinfeld does this look right. I am working on adding tests. |
Codecov Report
@@ Coverage Diff @@
## main #536 +/- ##
==========================================
+ Coverage 85.57% 85.60% +0.03%
==========================================
Files 758 759 +1
Lines 15525 15545 +20
Branches 1839 1842 +3
==========================================
+ Hits 13285 13307 +22
+ Misses 2209 2207 -2
Partials 31 31
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
aaron-steinfeld
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Description
Please include a summary of the change, motivation and context.
feat: adding sheet ref
Testing
Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.
Checklist:
Documentation
Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.