Skip to content

Query params resetting on nav item click #1531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 6, 2022
Merged

Query params resetting on nav item click #1531

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dcdf9c5
fix: environment selector resetting on lef navigation
Christian862 Apr 4, 2022
006961a
Merge branch 'main' of github.com:hypertrace/hypertrace-ui into Envir…
Christian862 Apr 5, 2022
bf94ac6
fix: revert previous solution, persist global query params for buildN…
Christian862 Apr 5, 2022
14b69a5
Merge branch 'main' of github.com:hypertrace/hypertrace-ui into Envir…
Christian862 Apr 6, 2022
70d85ac
Merge branch 'main' of github.com:hypertrace/hypertrace-ui into Envir…
Christian862 Apr 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion projects/common/src/navigation/navigation.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ export class NavigationService {
return {
path: params.path,
extras: {
queryParams: params?.queryParams ?? this.buildQueryParam(),
queryParams: { ...this.buildQueryParam(), ...(params?.queryParams ?? {}) },
queryParamsHandling: params?.queryParamsHandling,
replaceUrl: params?.replaceCurrentHistory,
relativeTo: params?.relativeTo
Expand Down