Skip to content

feat: support generating a color combination from a color palette #1510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Mar 30, 2022
Merged

feat: support generating a color combination from a color palette #1510

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
9cf4b17
feat: support generating a color combination from string id
arjunlalb Mar 29, 2022
a7d8174
fix: prettier fix
arjunlalb Mar 29, 2022
c6d8cf0
fix: incorporate color combinations into color palette
arjunlalb Mar 30, 2022
49c37ca
fix: renaming method
arjunlalb Mar 30, 2022
4f0d6c4
fix: prettier fix
arjunlalb Mar 30, 2022
c4625c5
fix: add test
arjunlalb Mar 30, 2022
5934794
Merge branch 'main' into color-combination-from-id
arjunlalb Mar 30, 2022
5f9293f
fix: lint fix
arjunlalb Mar 30, 2022
2163f0d
Merge branch 'main' into color-combination-from-id
arjunlalb Mar 30, 2022
04fb98f
fix: address comments
arjunlalb Mar 30, 2022
0dde3c4
Merge branch 'color-combination-from-id' of github.com:hypertrace/hyp…
arjunlalb Mar 30, 2022
925f82a
fix: prettier fix
arjunlalb Mar 30, 2022
f0ad954
Update projects/common/src/color/color-palette.ts
arjunlalb Mar 30, 2022
36cd774
fix: prettier fix
arjunlalb Mar 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion projects/common/src/color/color-palette.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,14 @@ describe('Color palette', () => {

test('should generate color for a string as expected from a limited set', () => {
const palette = new ColorPalette(['#fffbeb', '#140300', '#789ab7']);
expect(palette.getColorCombinationForId(2, 'test')).toEqual({
expect(palette.getColorCombinationForId('test', 2)).toEqual({
background: 'rgb(255, 251, 235)',
foreground: '#080909'
});
expect(palette.getColorCombinationForId('test')).toEqual({
background: 'rgb(20, 3, 0)',
foreground: '#FFFFFF'
});

});
});
6 changes: 4 additions & 2 deletions projects/common/src/color/color-palette.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,10 @@ export class ColorPalette {
return this.forNColors(count).map(color => ({ background: color, foreground: this.getContrast(color) }));
}

public getColorCombinationForId(colorCount: number, id: string): ColorCombination {
return this.getColorCombinations(colorCount)[Math.abs(hashCode(id)) % colorCount];
public getColorCombinationForId(id: string, colorPaletteSize?: number): ColorCombination {
const colorSetSize = colorPaletteSize ?? this.basisColors.length;

return this.getColorCombinations(colorSetSize)[Math.abs(hashCode(id)) % colorSetSize];
}

private getContrast(rgbColorString: string): string {
Expand Down