Skip to content

refactor: always use query limits #1496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 19, 2022
Merged

refactor: always use query limits #1496

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c0b475
refactor: always use query limits
aaron-steinfeld Mar 19, 2022
0b2a3df
test: update test limits
aaron-steinfeld Mar 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...src/shared/dashboard/widgets/trace-detail/data/api-trace-detail-data-source.model.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ describe('API Trace detail data source model', () => {
expect.objectContaining({
requestType: TRACE_GQL_REQUEST,
traceId: 'test',
spanLimit: 0,
spanLimit: 1000,
timestamp: undefined,
traceProperties: expect.arrayContaining([
expect.objectContaining({ name: 'tags' }),
Expand All @@ -99,7 +99,7 @@ describe('API Trace detail data source model', () => {
expect.objectContaining({
requestType: TRACE_GQL_REQUEST,
traceId: 'test',
spanLimit: 0,
spanLimit: 1000,
timestamp: undefined,
traceProperties: expect.arrayContaining([
expect.objectContaining({ name: 'tags' }),
Expand All @@ -119,7 +119,7 @@ describe('API Trace detail data source model', () => {
expect.objectContaining({
requestType: TRACE_GQL_REQUEST,
traceId: 'test',
spanLimit: 0,
spanLimit: 1000,
timestamp: new Date(1568907645141),
traceProperties: expect.arrayContaining([
expect.objectContaining({ name: 'tags' }),
Expand Down
4 changes: 2 additions & 2 deletions ...ity/src/shared/dashboard/widgets/trace-detail/data/trace-detail-data-source.model.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ describe('API Trace detail data source model', () => {
expect.objectContaining({
requestType: TRACE_GQL_REQUEST,
traceId: 'test',
spanLimit: 0,
spanLimit: 1000,
timestamp: undefined,
traceProperties: expect.arrayContaining([
expect.objectContaining({ name: 'tags' }),
Expand All @@ -94,7 +94,7 @@ describe('API Trace detail data source model', () => {
expect.objectContaining({
requestType: TRACE_GQL_REQUEST,
traceId: 'test',
spanLimit: 0,
spanLimit: 1000,
timestamp: new Date(1576364117792),
traceProperties: expect.arrayContaining([
expect.objectContaining({ name: 'tags' }),
Expand Down
2 changes: 1 addition & 1 deletion ...vability/src/shared/dashboard/widgets/trace-detail/data/trace-detail-data-source.model.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export class TraceDetailDataSourceModel extends GraphQlDataSourceModel<TraceDeta
requestType: TRACE_GQL_REQUEST,
traceType: this.trace[traceTypeKey],
traceId: this.trace[traceIdKey],
spanLimit: 0,
spanLimit: 1000,
timestamp: this.dateCoercer.coerce(this.startTime ?? this.trace.startTime),
traceProperties: this.getTraceAttributes().map(attribute =>
this.attributeSpecBuilder.attributeSpecificationForKey(attribute)
Expand Down