Skip to content

Feat | add error selectors #1480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 15, 2022
Merged

Feat | add error selectors #1480

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cea88cd
feat(notification): add alert type attribute
adisreyaj Mar 14, 2022
6a87679
feat(load-async): add alert type attribute
adisreyaj Mar 14, 2022
64b43ea
feat(not-found): add alert type
adisreyaj Mar 14, 2022
240a18d
refactor(error-selectors): update to use enums instead of strings
adisreyaj Mar 14, 2022
169ab1b
Merge branch 'main' into feat/error-selectors
adisreyaj Mar 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions projects/components/src/load-async/wrapper/load-async-wrapper.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ export const ASYNC_WRAPPER_PARAMETERS$ = new InjectionToken<Observable<LoadAsync
</ng-container>
<ng-container *ngSwitchDefault>
<ht-message-display
aria-live="polite"
role="alert"
[attr.data-alert-type]="state.type === '${LoadAsyncStateType.GenericError}' ? 'failure' : 'no-data'"
Copy link
Contributor

@arjunlalb arjunlalb Mar 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use the NotificationMode enum here for the failure string?

Copy link
Contributor Author

@adisreyaj adisreyaj Mar 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

[icon]="this.icon"
[title]="this.title"
[description]="this.description"
Expand Down
3 changes: 2 additions & 1 deletion projects/components/src/not-found/not-found.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { ButtonRole, ButtonStyle } from '../button/button';
styleUrls: ['./not-found.component.scss'],
template: `
<div class="not-found-container fill-container">
<div class="not-found-content">
<div class="not-found-content" role="alert" aria-live="assertive" [attr.data-alert-type]="'failure'">
Copy link
Contributor

@arjunlalb arjunlalb Mar 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here.

Copy link
Contributor Author

@adisreyaj adisreyaj Mar 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

<img class="not-found-image" src="${ImagesAssetPath.ErrorPage}" loading="lazy" alt="not found page" />
<div class="not-found-message-wrapper">
<div class="not-found-text-wrapper">
Expand All @@ -30,6 +30,7 @@ import { ButtonRole, ButtonStyle } from '../button/button';
})
export class NotFoundComponent {
public constructor(private readonly navService: NavigationService) {}

public goHome(): void {
this.navService.navigateToHome();
}
Expand Down
2 changes: 1 addition & 1 deletion projects/components/src/notification/notification.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import { IconSize } from '../icon/icon-size';
styleUrls: ['./notification.component.scss'],
changeDetection: ChangeDetectionStrategy.OnPush,
template: `
<div class="notification-container">
<div class="notification-container" role="alert" aria-live="polite" [attr.data-alert-type]="this.data.mode">
<ht-icon
[ngClass]="this.data.mode"
class="status-icon"
Expand Down