Skip to content

feat(navigable-tab): add change detection trigger #1410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 8, 2022
Merged

feat(navigable-tab): add change detection trigger #1410

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3931fb1
feat(navigable-tab): add change detection trigger
adisreyaj Feb 4, 2022
f48ef9c
refactor(navigable-tab): update change detection trigger mechanism
adisreyaj Feb 8, 2022
2c258b0
Merge branch 'main' into feat/navigable-tab-change-detection-trigger
adisreyaj Feb 8, 2022
3441dc1
refactor(navigable-tab): remove unused code
adisreyaj Feb 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions projects/components/src/tabs/navigable/navigable-tab-group.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,14 @@ import {
QueryList
} from '@angular/core';
import { ActivatedRoute } from '@angular/router';
import { Color, FeatureState, NavigationParams, NavigationParamsType, NavigationService } from '@hypertrace/common';
import {
Color,
FeatureState,
NavigationParams,
NavigationParamsType,
NavigationService,
queryListAndChanges$
} from '@hypertrace/common';
import { merge, Observable } from 'rxjs';
import { distinctUntilChanged, map, startWith, tap } from 'rxjs/operators';
import { NavigableTabComponent } from './navigable-tab.component';
Expand All @@ -20,7 +27,7 @@ import { NavigableTabComponent } from './navigable-tab.component';
template: `
<div class="tab-group">
<nav mat-tab-nav-bar *htLetAsync="this.activeTab$ as activeTab" disableRipple>
<ng-container *ngFor="let tab of this.tabs">
<ng-container *ngFor="let tab of this.tabs$ | async">
<ng-container *ngIf="!tab.hidden">
<div class="tab-button" *htIfFeature="tab.featureFlags | htFeature as featureState">
<ht-link
Expand Down Expand Up @@ -49,23 +56,28 @@ import { NavigableTabComponent } from './navigable-tab.component';
</nav>
<div class="divider"></div>
</div>

<!-- When tabs input changes, change detection will be triggered automatically -->
<ng-container *ngIf="tabs.changes | async"></ng-container>
`
})
export class NavigableTabGroupComponent implements AfterContentInit {
@ContentChildren(NavigableTabComponent)
public tabs!: QueryList<NavigableTabComponent>;
private readonly tabs!: QueryList<NavigableTabComponent>;

@Output()
public readonly tabChange: EventEmitter<string | undefined> = new EventEmitter<string | undefined>();

public activeTab$?: Observable<NavigableTabComponent | undefined>;
public tabs$!: Observable<NavigableTabComponent[]>;

public constructor(
public readonly navigationService: NavigationService,
private readonly activatedRoute: ActivatedRoute
) {}

public ngAfterContentInit(): void {
this.tabs$ = queryListAndChanges$(this.tabs).pipe(map(list => list.toArray()));
this.activeTab$ = merge(this.navigationService.navigation$, this.tabs.changes).pipe(
startWith(undefined),
map(() => this.findActiveTab()),
Expand Down