Skip to content

refactor: adding filters to data source #1372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jan 14, 2022
Merged

refactor: adding filters to data source #1372

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
cbb0fd1
refactor: adding filters and make largest auto value as default
anandtiwary Jan 13, 2022
d1fa877
Merge branch 'main' into update-filters-default-auto
anandtiwary Jan 13, 2022
866e57f
refactor: fixing lint error
anandtiwary Jan 13, 2022
ff2ed17
refactor: fixing test
anandtiwary Jan 13, 2022
02c2f3d
refactor: fixing tests
anandtiwary Jan 13, 2022
c0382a9
Merge branch 'update-filters-default-auto' of github.com:hypertrace/h…
anandtiwary Jan 13, 2022
1bf583c
Merge branch 'main' into update-filters-default-auto
anandtiwary Jan 13, 2022
7091100
refactor: addressing review comments
anandtiwary Jan 13, 2022
9c9f0d8
revert: auto interval chagnes
anandtiwary Jan 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...dashboard/data/graphql/trace/timeseries/trace-metric-timeseries-data-source.model.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ describe('Trace metric timeseries data source model', () => {
requestType: EXPLORE_GQL_REQUEST,
timeRange: new GraphQlTimeRange(testTimeRange.startTime, testTimeRange.endTime),
context: ObservabilityTraceType.Api,
filters: [],
interval: testInterval,
limit: 10000,
selections: [model.specification]
Expand Down
10 changes: 6 additions & 4 deletions ...vability/src/shared/dashboard/data/graphql/trace/trace-series-values-data-source.model.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,22 +10,24 @@ import {
GraphQlExploreResult
} from '../../../../graphql/request/handlers/explore/explore-query';
import { GraphQlDataSourceModel } from '../graphql-data-source.model';
import { GraphQlFilter } from './../../../../graphql/model/schema/filter/graphql-filter';

export abstract class TraceSeriesValuesDataSourceModel<TData> extends GraphQlDataSourceModel<TData> {
protected abstract specification: ExploreSpecification;

protected fetchSpecificationData(interval: TimeDuration): Observable<GraphQlExploreResult[]> {
return this.query<ExploreGraphQlQueryHandlerService>(() => this.buildRequest(interval)).pipe(
map(response => response.results)
);
return this.query<ExploreGraphQlQueryHandlerService>(inheritedFilters =>
this.buildRequest(interval, inheritedFilters)
).pipe(map(response => response.results));
}

private buildRequest(interval: TimeDuration): GraphQlExploreRequest {
private buildRequest(interval: TimeDuration, inheritedFilters: GraphQlFilter[] = []): GraphQlExploreRequest {
return {
requestType: EXPLORE_GQL_REQUEST,
timeRange: this.getTimeRangeOrThrow(),
context: ObservabilityTraceType.Api,
interval: interval,
filters: [...inheritedFilters],
limit: 10000,
selections: [this.specification]
};
Expand Down