-
Notifications
You must be signed in to change notification settings - Fork 11
Trace drilldown to explorer screen #1098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
itssharmasandeep
merged 13 commits into
hypertrace:main
from
jyothishjose6190:trace_drilldown_search_1076
Sep 27, 2021
Merged
Changes from 11 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
df3b19b
fix: trace drilldown to search
jyothishjose6190 b9719c4
fix: lint errors
jyothishjose6190 68a4ea6
fix: span drilldown
jyothishjose6190 660e6fc
fix: import issues fixed
jyothishjose6190 d00cf46
feat: search span id from waterfall chart
jyothishjose6190 36d7814
feat: search trace id
jyothishjose6190 51d9b3b
fix: style clean up
jyothishjose6190 fa4ceb6
fix: trace, span search explorer - clean up
jyothishjose6190 125cb26
fix: added test cases for span and trace search
jyothishjose6190 3030d2b
fix: fixed lint errors
jyothishjose6190 97af327
fix: import error
jyothishjose6190 58c5efd
fix: trace, span search - ui clean up
jyothishjose6190 484cc8f
Merge branch 'main' into trace_drilldown_search_1076
itssharmasandeep File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
59 changes: 59 additions & 0 deletions
59
projects/observability/src/pages/api-trace-detail/api-trace-detail.page.component.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| import { fakeAsync, tick } from '@angular/core/testing'; | ||
| import { MemoizeModule, NavigationService } from '@hypertrace/common'; | ||
| import { LoadAsyncModule } from '@hypertrace/components'; | ||
| import { createComponentFactory, mockProvider } from '@ngneat/spectator/jest'; | ||
| import { MockComponent } from 'ng-mocks'; | ||
| import { of } from 'rxjs'; | ||
| import { ExploreFilterLinkComponent } from '../../shared/components/explore-filter-link/explore-filter-link.component'; | ||
| import { ExplorerService } from '../explorer/explorer-service'; | ||
| import { ApiTraceDetailPageComponent } from './api-trace-detail.page.component'; | ||
| import { ApiTraceDetails, ApiTraceDetailService } from './api-trace-detail.service'; | ||
| describe('Api Trace Details Page Component', () => { | ||
| const mockTraceDetails: ApiTraceDetails = { | ||
| id: 'test-id', | ||
| traceId: 'test-123', | ||
| type: 'trace-type', | ||
| timeString: 'test-time-string', | ||
| titleString: 'test-title', | ||
| startTime: 'test-start-time' | ||
| }; | ||
|
|
||
| const createComponent = createComponentFactory({ | ||
| component: ApiTraceDetailPageComponent, | ||
| shallow: true, | ||
| providers: [ | ||
| mockProvider(NavigationService), | ||
| mockProvider(ExplorerService, { | ||
| buildNavParamsWithFilters: jest.fn().mockReturnValue(of('traceId_eq_test-123')) | ||
| }) | ||
| ], | ||
| imports: [LoadAsyncModule, MemoizeModule], | ||
| componentProviders: [ | ||
| mockProvider(ApiTraceDetailService, { | ||
| fetchTraceDetails: jest.fn().mockReturnValue(of(mockTraceDetails)) | ||
| }) | ||
| ], | ||
| declarations: [MockComponent(ExploreFilterLinkComponent)] | ||
| }); | ||
|
|
||
| test('should render content correctly', fakeAsync(() => { | ||
| const spectator = createComponent(); | ||
|
|
||
| spectator.click('.label'); | ||
| tick(); | ||
| expect(spectator.inject(NavigationService).navigateBack).toHaveBeenCalled(); | ||
|
|
||
| spectator.click('.full-trace-button'); | ||
| tick(); | ||
| expect(spectator.inject(NavigationService).navigateWithinApp).toHaveBeenCalledWith([ | ||
| '/trace', | ||
| mockTraceDetails.traceId, | ||
| { startTime: mockTraceDetails.startTime } | ||
| ]); | ||
| })); | ||
|
|
||
| test('should render explorer link component', fakeAsync(() => { | ||
| const spectator = createComponent(); | ||
| expect(spectator.query(ExploreFilterLinkComponent)?.paramsOrUrl).toBe('traceId_eq_test-123'); | ||
| })); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
51 changes: 51 additions & 0 deletions
51
projects/observability/src/pages/trace-detail/trace-detail.page.component.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| import { fakeAsync, tick } from '@angular/core/testing'; | ||
| import { MemoizeModule, NavigationService } from '@hypertrace/common'; | ||
| import { LoadAsyncModule } from '@hypertrace/components'; | ||
| import { createComponentFactory, mockProvider } from '@ngneat/spectator/jest'; | ||
| import { MockComponent } from 'ng-mocks'; | ||
| import { of } from 'rxjs'; | ||
| import { ExploreFilterLinkComponent } from '../../shared/components/explore-filter-link/explore-filter-link.component'; | ||
| import { ExplorerService } from '../explorer/explorer-service'; | ||
| import { TraceDetailPageComponent } from './trace-detail.page.component'; | ||
| import { TraceDetails, TraceDetailService } from './trace-detail.service'; | ||
| describe('Trace Details Page Component', () => { | ||
| const mockTraceDetails: TraceDetails = { | ||
| id: 'test-id', | ||
| entrySpanId: 'test-123', | ||
| type: 'trace-type', | ||
| timeString: 'test-time-string', | ||
| titleString: 'test-title', | ||
| startTime: 'test-start-time' | ||
| }; | ||
|
|
||
| const createComponent = createComponentFactory({ | ||
| component: TraceDetailPageComponent, | ||
| shallow: true, | ||
| providers: [ | ||
| mockProvider(NavigationService), | ||
| mockProvider(ExplorerService, { | ||
| buildNavParamsWithFilters: jest.fn().mockReturnValue(of('traceId_eq_test-123')) | ||
| }) | ||
| ], | ||
| imports: [LoadAsyncModule, MemoizeModule], | ||
| componentProviders: [ | ||
| mockProvider(TraceDetailService, { | ||
| fetchTraceDetails: jest.fn().mockReturnValue(of(mockTraceDetails)) | ||
| }) | ||
| ], | ||
| declarations: [MockComponent(ExploreFilterLinkComponent)] | ||
| }); | ||
|
|
||
| test('should render content correctly', fakeAsync(() => { | ||
| const spectator = createComponent(); | ||
|
|
||
| spectator.click('.label'); | ||
| tick(); | ||
| expect(spectator.inject(NavigationService).navigateBack).toHaveBeenCalled(); | ||
| })); | ||
|
|
||
| test('should render explorer link component', fakeAsync(() => { | ||
| const spectator = createComponent(); | ||
| expect(spectator.query(ExploreFilterLinkComponent)?.paramsOrUrl).toBe('traceId_eq_test-123'); | ||
| })); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add some tests for this? (and in the other components)