Trace drilldown to explorer screen #1098
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,19 @@ | ||
| import { CommonModule } from '@angular/common'; | ||
| import { NgModule } from '@angular/core'; | ||
| import { RouterModule } from '@angular/router'; | ||
| import { FormattingModule, HtRoute, MemoizeModule } from '@hypertrace/common'; | ||
| import { | ||
| CopyShareableLinkToClipboardModule, | ||
| DownloadJsonModule, | ||
| IconModule, | ||
| LabelModule, | ||
| LinkModule, | ||
| LoadAsyncModule, | ||
| NavigableTabModule, | ||
| SummaryValueModule, | ||
| TooltipModule | ||
| } from '@hypertrace/components'; | ||
| import { ExploreFilterLinkModule } from '../../shared/components/explore-filter-link/explore-filter-link.module'; | ||
| import { LogEventsTableModule } from '../../shared/components/log-events/log-events-table.module'; | ||
| import { NavigableDashboardModule } from '../../shared/dashboard/dashboard-wrapper/navigable-dashboard.module'; | ||
| import { TracingDashboardModule } from '../../shared/dashboard/tracing-dashboard.module'; | ||
|
|
@@ -47,10 +49,13 @@ const ROUTE_CONFIG: HtRoute[] = [ | |
| imports: [ | ||
| RouterModule.forChild(ROUTE_CONFIG), | ||
| CommonModule, | ||
| ExploreFilterLinkModule, | ||
| LabelModule, | ||
| TracingDashboardModule, | ||
| IconModule, | ||
| SummaryValueModule, | ||
| LinkModule, | ||
|
||
| MemoizeModule, | ||
| TooltipModule, | ||
| LoadAsyncModule, | ||
| FormattingModule, | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,11 @@ | ||
| import { MemoizeModule } from '@hypertrace/common'; | ||
| import { LoadAsyncModule, OverlayService } from '@hypertrace/components'; | ||
| import { mockDashboardWidgetProviders } from '@hypertrace/dashboards/testing'; | ||
| import { createComponentFactory, mockProvider } from '@ngneat/spectator/jest'; | ||
| import { MockComponent } from 'ng-mocks'; | ||
| import { of } from 'rxjs'; | ||
| import { ExplorerService } from '../../../../pages/explorer/explorer-service'; | ||
| import { ExploreFilterLinkComponent } from '../../../components/explore-filter-link/explore-filter-link.component'; | ||
| import { WaterfallWidgetRendererComponent } from './waterfall-widget-renderer.component'; | ||
| import { WaterfallChartComponent } from './waterfall/waterfall-chart.component'; | ||
|
|
||
|
|
@@ -14,9 +17,13 @@ describe('Waterfall widget renderer component', () => { | |
| const createComponent = createComponentFactory<WaterfallWidgetRendererComponent>({ | ||
| component: WaterfallWidgetRendererComponent, | ||
| shallow: true, | ||
| imports: [LoadAsyncModule, MemoizeModule], | ||
| providers: [ | ||
| ...mockDashboardWidgetProviders(mockModel), | ||
| mockProvider(OverlayService), | ||
| mockProvider(ExplorerService) | ||
| ], | ||
| declarations: [MockComponent(WaterfallChartComponent), MockComponent(ExploreFilterLinkComponent)] | ||
|
Contributor
There was a problem hiding this comment. Can we add some tests for this? (and in the other components) |
||
| }); | ||
|
|
||
| test('renders the widget', () => { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,12 +8,15 @@ import { | |
| ViewChild | ||
| } from '@angular/core'; | ||
| import { IconType } from '@hypertrace/assets-library'; | ||
| import { NavigationParams } from '@hypertrace/common'; | ||
| import { ButtonStyle, FilterOperator, OverlayService, SheetRef, SheetSize } from '@hypertrace/components'; | ||
| import { WidgetRenderer } from '@hypertrace/dashboards'; | ||
| import { Renderer } from '@hypertrace/hyperdash'; | ||
| import { RendererApi, RENDERER_API } from '@hypertrace/hyperdash-angular'; | ||
| import { isEmpty } from 'lodash-es'; | ||
| import { Observable } from 'rxjs'; | ||
| import { ExplorerService } from '../../../../pages/explorer/explorer-service'; | ||
| import { ScopeQueryParam } from '../../../../pages/explorer/explorer.component'; | ||
| import { SpanDetailLayoutStyle } from '../../../components/span-detail/span-detail-layout-style'; | ||
| import { SpanDetailTab } from '../../../components/span-detail/span-detail-tab'; | ||
| import { WaterfallWidgetModel } from './waterfall-widget.model'; | ||
|
|
@@ -67,12 +70,18 @@ import { MarkerSelection, WaterfallChartComponent } from './waterfall/waterfall- | |
| [activeTabLabel]="this.activeTabLabel" | ||
| (closed)="this.closeSheet()" | ||
| > | ||
| <ht-explore-filter-link | ||
| class="filter-link" | ||
| [paramsOrUrl]="getExploreNavigationParams | htMemoize: this.selectedData | async" | ||
| htTooltip="See traces in Explorer" | ||
|
||
| > | ||
| <ht-summary-value | ||
| data-sensitive-pii | ||
| icon="${IconType.SpanId}" | ||
| label="Span ID" | ||
| [value]="this.selectedData!.id" | ||
| ></ht-summary-value> | ||
| </ht-explore-filter-link> | ||
| </ht-span-detail> | ||
| </div> | ||
| </ng-template> | ||
|
|
@@ -94,7 +103,8 @@ export class WaterfallWidgetRendererComponent | |
| public constructor( | ||
| @Inject(RENDERER_API) api: RendererApi<WaterfallWidgetModel>, | ||
| changeDetector: ChangeDetectorRef, | ||
| private readonly overlayService: OverlayService, | ||
| private readonly explorerService: ExplorerService | ||
| ) { | ||
| super(api, changeDetector); | ||
| } | ||
|
|
@@ -141,4 +151,9 @@ export class WaterfallWidgetRendererComponent | |
| protected fetchData(): Observable<WaterfallData[]> { | ||
| return this.model.getData(); | ||
| } | ||
|
|
||
| public getExploreNavigationParams = (selectedData: WaterfallData | undefined): Observable<NavigationParams> => | ||
| this.explorerService.buildNavParamsWithFilters(ScopeQueryParam.Spans, [ | ||
| { field: 'id', operator: FilterOperator.Equals, value: selectedData!.id } | ||
| ]); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,6 @@ | ||
| import { CommonModule } from '@angular/common'; | ||
| import { NgModule } from '@angular/core'; | ||
| import { MemoizeModule } from '@hypertrace/common'; | ||
| import { | ||
| ButtonModule, | ||
| IconModule, | ||
|
|
@@ -11,6 +12,7 @@ import { | |
| TooltipModule | ||
| } from '@hypertrace/components'; | ||
| import { DashboardCoreModule } from '@hypertrace/hyperdash-angular'; | ||
| import { ExploreFilterLinkModule } from '../../../components/explore-filter-link/explore-filter-link.module'; | ||
| import { SpanDetailModule } from '../../../components/span-detail/span-detail.module'; | ||
| import { WaterfallWidgetRendererComponent } from './waterfall-widget-renderer.component'; | ||
| import { WaterfallWidgetModel } from './waterfall-widget.model'; | ||
|
|
@@ -24,7 +26,9 @@ import { WaterfallChartModule } from './waterfall/waterfall-chart.module'; | |
| renderers: [WaterfallWidgetRendererComponent] | ||
| }), | ||
| CommonModule, | ||
| ExploreFilterLinkModule, | ||
| LabelModule, | ||
| MemoizeModule, | ||
| SpanDetailModule, | ||
| OverlayModule, | ||
| TooltipModule, | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1