-
Notifications
You must be signed in to change notification settings - Fork 11
feat: adding icon properties #1063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1063 +/- ##
=======================================
Coverage 85.08% 85.08%
=======================================
Files 822 822
Lines 16924 16931 +7
Branches 2045 2045
=======================================
+ Hits 14399 14406 +7
Misses 2494 2494
Partials 31 31
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
|
One thing we may want to tweak is whether the border is inset or outset. Outset is fine for now, but may want to switch to inset or make it configurable. |
Description
Testing
Visual testing
Checklist:
Documentation
Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.