Skip to content

Conversation

@anandtiwary
Copy link
Contributor

@anandtiwary anandtiwary commented Jul 16, 2021

Description

Please include a summary of the change, motivation and context.
refactor: adding an option to hide time range in page header

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@anandtiwary anandtiwary requested a review from a team as a code owner July 16, 2021 19:41
@codecov
Copy link

codecov bot commented Jul 16, 2021

Codecov Report

Merging #1001 (c72e8de) into main (47a0ae0) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1001   +/-   ##
=======================================
  Coverage   85.03%   85.03%           
=======================================
  Files         821      821           
  Lines       16837    16838    +1     
  Branches     2180     2180           
=======================================
+ Hits        14317    14318    +1     
  Misses       2489     2489           
  Partials       31       31           
Impacted Files Coverage Δ
...header/application/application-header.component.ts 50.00% <100.00%> (+7.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47a0ae0...c72e8de. Read the comment docs.

@github-actions

This comment has been minimized.

@anandtiwary anandtiwary merged commit a75a8f5 into main Jul 16, 2021
@anandtiwary anandtiwary deleted the hide-time-range-with-option branch July 16, 2021 20:08
@github-actions
Copy link

Unit Test Results

    4 files  ±0  262 suites  ±0   16m 14s ⏱️ +57s
944 tests ±0  944 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
951 runs  ±0  951 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit a75a8f5. ± Comparison against base commit 47a0ae0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants