Skip to content

Conversation

@suresh-prakash
Copy link
Contributor

@suresh-prakash suresh-prakash commented Mar 10, 2022

Description

Aggregations and grouping can now be applied on multi-value attributes

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@suresh-prakash suresh-prakash requested review from a team and skjindal93 March 10, 2022 10:29
@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #173 (d5541a9) into main (a08e226) will increase coverage by 0.19%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #173      +/-   ##
============================================
+ Coverage     63.46%   63.66%   +0.19%     
- Complexity      527      541      +14     
============================================
  Files            99      102       +3     
  Lines          4092     4131      +39     
  Branches        455      460       +5     
============================================
+ Hits           2597     2630      +33     
- Misses         1269     1275       +6     
  Partials        226      226              
Flag Coverage Δ
integration 63.66% <66.66%> (+0.19%) ⬆️
unit 46.85% <66.66%> (+0.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...entity/query/service/converter/QueryConverter.java 6.06% <0.00%> (-3.47%) ⬇️
...r/ArrayElementSuffixAddingIdentifierConverter.java 50.00% <0.00%> (ø)
...entifier/ArraySuffixAddingIdentifierConverter.java 66.66% <0.00%> (ø)
...identifier/MapSuffixAddingIdentifierConverter.java 66.66% <0.00%> (ø)
...fier/PrimitiveSuffixAddingIdentifierConverter.java 66.66% <0.00%> (ø)
...er/identifier/SuffixAddingIdentifierConverter.java 80.00% <66.66%> (+60.00%) ⬆️
...ntity/query/service/converter/ConverterModule.java 100.00% <100.00%> (ø)
...y/query/service/converter/FromClauseConverter.java 100.00% <100.00%> (ø)
...onverter/aggregation/AggregationAliasProvider.java 100.00% <100.00%> (+15.38%) ⬆️
...nverter/aggregation/AggregationColumnProvider.java 100.00% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a08e226...d5541a9. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@suresh-prakash suresh-prakash merged commit 82cea6f into main Mar 10, 2022
@suresh-prakash suresh-prakash deleted the multi_value_attribute_grouping_support branch March 10, 2022 13:50
@github-actions
Copy link

Unit Test Results

  52 files  +2    52 suites  +2   27s ⏱️ +3s
220 tests +5  217 ✔️ +5  3 💤 ±0  0 ❌ ±0 

Results for commit 82cea6f. ± Comparison against base commit a08e226.

suddendust pushed a commit to suddendust/entity-service that referenced this pull request Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants