Can Disable Camera Rotation #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think @zenangst did something similar here, I'll let him take a step up on this. Also, sorry about the late replay, we should answer within a week, but this has gone places, a lot of work in the office and stuff to do. Sorry about that. |
|
For me, calling it camera rotation is a bit confusing but that is beside the point. To clarify, I worked a bit on the rotation, not the option to disable the front-facing camera. @kernjackson could you fix the merge conflicts on this PR? 😎 |
|
Right, canRotate is kind of confusing. I was just trying to follow the existing naming convention. Maybe could have called it banSelfies or something like that. 😄 |
|
@kernjackson thanks mate! Sorry for the delay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a configuration item for disabling camera rotation button.