Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature loading indicator #53

Merged
merged 6 commits into from
Nov 11, 2015
Merged

Conversation

zenangst
Copy link
Contributor

The process of fetching images from the library is doing asynchronously and can be a bit slow if you take a rapid series of images.

To work around this issue, this PR adds an UIActivityIndicatorView that adds on top of the image stack to indicate that the devices is loading photos.

img_0329
img_0335

lazy var activityView: UIActivityIndicatorView = {
let view = UIActivityIndicatorView()
view.alpha = 0.0
return view
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd ad a return here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Christoffer Winterkvist added 2 commits November 11, 2015 15:49
RamonGilabert added a commit that referenced this pull request Nov 11, 2015
@RamonGilabert RamonGilabert merged commit a57ba4f into master Nov 11, 2015
@RamonGilabert RamonGilabert deleted the feature/loading-indicator branch November 11, 2015 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants