Disable "flash" button if capture device has no flash. #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -49,7 +50,13 @@ class CameraView: UIViewController { | |||
|
|
|||
| let captureSession = AVCaptureSession() | |||
| let devices = AVCaptureDevice.devices() | |||
| var captureDevice: AVCaptureDevice? | |||
| var captureDevice: AVCaptureDevice? { | |||
| didSet { | |||
|
I did a quick test on 4S and found few strange bugs: UPD |
RamonGilabert
added a commit
that referenced
this pull request
Oct 8, 2015
Disable "flash" button if capture device has no flash.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed a crash when user may tap "flash" button on device which has no flash.
For example, it happened to me on iPad 3.
I didn't check for
front/backcamera switch as all devices that support iOS 8+ have 2 cameras.This is how it looks on iPad: