Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/external configuration #40

Merged
merged 6 commits into from
Oct 5, 2015
Merged

Conversation

RamonGilabert
Copy link
Contributor

No description provided.

@@ -1,6 +1,13 @@
import UIKit

public class PickerConfiguration {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it could be just Configuration with var imagePicker?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, but I don't want to conflict with Lightbox and stuff like that, what do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But you can use it like ImagePicker.Configuration, with module name, and also - do we have something else except ImagePickerConfiguration, I mean why do we need 2 classes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes just thought about it, changing it!

@RamonGilabert
Copy link
Contributor Author

@vadymmarkov done I guess? 😄

zenangst added a commit that referenced this pull request Oct 5, 2015
@zenangst zenangst merged commit d072f88 into master Oct 5, 2015
@zenangst zenangst deleted the feature/external-configuration branch October 5, 2015 11:25
@zenangst
Copy link
Contributor

zenangst commented Oct 5, 2015

community-gifs-community-21080243-500-194

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants