Improves the security in ImagePicker #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -21,7 +21,7 @@ public class ImagePickerController: UIViewController { | |||
|
|
|||
| lazy public var galleryView: ImageGalleryView = { [unowned self] in | |||
| let galleryView = ImageGalleryView() | |||
| galleryView.delegate = self | |||
| //galleryView.delegate = self | |||
There was a problem hiding this comment.
@RamonGilabert what's going on here?
|
@zenangst fixed. |
zenangst
added a commit
that referenced
this pull request
Sep 23, 2015
Improves the security in ImagePicker
|
Didn't have time to comment, spotted this PR only now. Will apply changes in a new PR then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We got some crashes because we were using ! a lot. Now we are not using it anywhere, pretty much.
BONUS: