Improvements/refactoring matching desings #18
Conversation
|
|
||
| func setupConstraints() { | ||
|
|
||
| for attribute: NSLayoutAttribute in [.CenterX, .CenterY] { |
There was a problem hiding this comment.
Of course, I understand, why all the hassle with not adding dependencies, but after trying Masonry/Cartography default AutoLayout syntax looks really weird.
Nice idea to keep it away from logic-related code.
On the other hand, may be overcomplicated if file grows. Splitting into 2 separate files i.e. Class.swift + ClassLayout.swift may be an option if there are too much constraints.
RamonGilabert
changed the title
| @@ -47,21 +47,21 @@ public class ImageGalleryView: UIView { | |||
| let view = UIView() | |||
| view.setTranslatesAutoresizingMaskIntoConstraints(false) | |||
| view.addGestureRecognizer(self.panGestureRecognizer) | |||
| view.backgroundColor = self.configuration.backgroundColor | |||
| view.backgroundColor = UIColor.blackColor().colorWithAlphaComponent(0.6) | |||
|
@hyperoslo/myshop-ios This looks awesome! What do you guys think? |
| static let indicatorWidth: CGFloat = 41 | ||
| static let indicatorHeight: CGFloat = 8 | ||
| } | ||
|
|
||
| lazy public var collectionView: UICollectionView = { [unowned self] in | ||
| lazy public var collectionView: UICollectionView = { |
|
@RamonGilabert Looks great! |
…ng-desings Improvements/refactoring matching desings
|
🍶 |
|
☕ |
| @@ -3,9 +3,9 @@ import UIKit | |||
| public class ImageStack { | |||
|
|
|||
| public struct Notifications { | |||
| public static let imageDidPush = "imageDidPush:" | |||
There was a problem hiding this comment.
Hmmm. This needs to be checked.
There was a problem hiding this comment.
It's a notification name, not a method. The name of the notification is imageDidPush, not imageDidPush:.
There was a problem hiding this comment.
Yep, I did few tests to check that it works correctly. Seems that I've just copied selector.
No description provided.