Use serial sessionQueue because most session calls are blocking #146

onmyway133 · 2016-04-20T13:09:36Z

Especially startRunning

The startRunning method is a blocking call which can take some time, therefore you should perform session setup on a serial queue so that the main queue isn't blocked (which keeps the UI responsive). See AVCam-iOS: Using AVFoundation to Capture Images and Movies for an implementation example.

…cially startRunning

zenangst · 2016-04-21T08:29:29Z

Source/CameraView/CameraView.swift

+      self.captureSession.startRunning()
+      self.stillImageOutput = AVCaptureStillImageOutput()
+      self.stillImageOutput?.outputSettings = [AVVideoCodecKey: AVVideoCodecJPEG]
+      self.captureSession.addOutput(self.stillImageOutput)


Should we capture weak self here?

@zenangst I think we don't need to, because it is dispatch_async 😄

Use serial sessionQueue because most session calls are blocking, espe…

c950ddb

…cially startRunning

onmyway133 assigned RamonGilabert Apr 20, 2016

zenangst reviewed Apr 21, 2016
View reviewed changes

zenangst merged commit 1058a20 into master Apr 21, 2016

zenangst deleted the fix/session_queue branch April 21, 2016 08:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use serial sessionQueue because most session calls are blocking #146

Use serial sessionQueue because most session calls are blocking #146

onmyway133 commented Apr 20, 2016

zenangst Apr 21, 2016

onmyway133 Apr 21, 2016

Use serial sessionQueue because most session calls are blocking #146

Use serial sessionQueue because most session calls are blocking #146

Conversation

onmyway133 commented Apr 20, 2016

zenangst Apr 21, 2016

Choose a reason for hiding this comment

onmyway133 Apr 21, 2016

Choose a reason for hiding this comment