Remove sessionPreset #134
Merged
Remove sessionPreset #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix issue #124. But i do not have iPad 2 to test. May be you guys can help here @zenangst
We should avoid using these sessionPreset
AVCaptureSessionPreset1280x720AVCaptureSessionPreset1920x1080AVCaptureSessionPreset640x480.We better use
AVCaptureSessionPresetHighif we are trying to capture the best quality. AlsoAVCaptureSessionPresetHighvaries depending on the device.Even more
AVCaptureSessionPresetHighis default value therefore no need to set either.In fact i am wondering was there a specific reason to use
AVCaptureSessionPreset1280x720AVCaptureSessionPreset1920x1080AVCaptureSessionPreset640x480? Am i missing something?