fix reloadAssets still showing pictures as selected in collection view #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aronse Hey man! Thanks for the pull request. One question, how come you added a new demo? We prefer not to use Storyboards in our examples because it makes it harder to review here on GitHub. Hope you understand 😎 |
| NSNotificationCenter.defaultCenter().addObserver(self, | ||
| selector: "didReloadAssets:", | ||
| name: ImageStack.Notifications.stackDidReload, |
There was a problem hiding this comment.
Would you mind cleaning up the whitespace in this method call?
|
Oh I see now, you added the Storyboard to the existing demo. Sorry for the misunderstanding in my previous comment, however, it would be cleaner if you just left it like it was before in the old demo. |
|
Sure! I just changed the demo to illustrate the issue. Let me put back the old one ;) |
|
@zenangst Alright, all good. I also squashed my changes into one single commit so it's easier to read/merge. Let me know if you need anything else 😎 |
zenangst
added a commit
that referenced
this pull request
Feb 15, 2016
…onview fix reloadAssets still showing pictures as selected in collection view
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when using ImagePickerController as a lazy var, we are able to reset to the default state using
imagePicker.stack.resetAssets([]), which works but does not reset the collection view selection (pictures are still marked as selected), as well as the collectionViewcontentOffset(see #70)