Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Css refactor #62

Merged
merged 19 commits into from
Dec 12, 2016
Merged

Css refactor #62

merged 19 commits into from
Dec 12, 2016

Conversation

bcomnes
Copy link
Contributor

@bcomnes bcomnes commented Dec 11, 2016

This is a fatty refactor, that isn't quite complete.

Basically, it strips out a bunch of weird crap I was experimenting with before, with a new experiment that I seem to like a lot better and think we can roll with.

This is a partial manual port of photon.css to csjs and is tightly coupled with our components.

Here is what is still busted:

  • Button styles
  • Form styles (e.g. preferences)
  • Table view.

Heres whats working:

I'm thinking about the following two options:

  • Finish up the CSS porting so that everything looks the same as before. This would be a clean transition from what we were doing before to now.
  • Merge it in now, looking nice and ugly and slowly tidy things up as we go along. This would allow us to track dependencies again and do things like upgrade to choo 4.

@bcomnes
Copy link
Contributor Author

bcomnes commented Dec 11, 2016

screen shot 2016-12-11 at 3 54 38 pm

@bcomnes
Copy link
Contributor Author

bcomnes commented Dec 12, 2016

Gonna go with option b

@bcomnes bcomnes merged commit 7777970 into master Dec 12, 2016
@bcomnes bcomnes deleted the css-refactor branch December 12, 2016 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant