Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable browserify build process #240

Merged
merged 2 commits into from
Oct 30, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion main/windows/player.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
var { BrowserWindow } = require('electron')
var windowStateKeeper = require('electron-window-state')
var path = require('path')
var PLAYER_WINDOW = 'file://' + path.resolve(__dirname, '..', '..', 'renderer', 'index.html')
var isDev = require('electron-is-dev')
var PLAYER_WINDOW = isDev
? 'file://' + path.resolve(__dirname, '..', '..', 'renderer', 'index-dev.html')
: 'file://' + path.resolve(__dirname, '..', '..', 'renderer', 'index.html')

var player = module.exports = {
init,
Expand Down
47 changes: 35 additions & 12 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,10 @@
"electron-context-menu": "^0.9.0",
"electron-debug": "^1.4.0",
"electron-default-menu": "^1.0.1",
"electron-is-dev": "^0.3.0",
"electron-store": "^1.1.0",
"electron-window-state": "^4.0.2",
"entypo": "^2.0.0",
"entypo": "^2.1.0",
"file-url": "^2.0.2",
"flush-write-stream": "^1.0.2",
"folder-walker": "^3.0.0",
Expand All @@ -61,27 +62,36 @@
},
"devDependencies": {
"@tap-format/spec": "^0.2.0",
"browserify": "^14.5.0",
"budo": "^10.0.4",
"buffer-equal": "^1.0.0",
"bundle-collapser": "^1.3.0",
"common-shakeify": "^0.4.4",
"concat-stream": "^1.6.0",
"dependency-check": "^2.8.0",
"electron": "1.7.8",
"electron-builder": "^19.33.0",
"electron-rebuild": "^1.5.11",
"electron-renderify": "0.0.2",
"envify": "^4.1.0",
"is-buffer": "^1.1.5",
"npm-run-all": "^4.0.1",
"npm-run-all": "^4.1.1",
"snazzy": "^7.0.0",
"spectron": "^3.7.1",
"standard": "^10.0.1",
"tape": "^4.6.3",
"temporary-directory": "^1.0.2",
"xvfb-maybe": "^0.2.1"
"unassertify": "^2.0.5",
"xvfb-maybe": "^0.2.1",
"yo-yoify": "^4.0.0"
},
"homepage": "https://github.com/hypermodules/hyperamp",
"keywords": [
"amp",
"hyper",
"music",
"player"
"player",
"hyperamp",
"library"
],
"license": "GPL-3.0",
"main": "main/index.js",
Expand All @@ -91,17 +101,30 @@
"url": "git+https://github.com/hypermodules/hyperamp.git"
},
"scripts": {
"build": "build --dir",
"clear": "electron scripts/clear.js",
"dist": "build",
"prod": "ELECTRON_IS_DEV=0 npm start",
"rebuild": "electron-rebuild",
"start": "electron main",
"start": "run-s watch",
"build": "run-s clean build:*",
"build:js": "browserify --debug renderer/index.js -o renderer/dist/bundle.js",
"build:electron": "build --dir",
"prod": "run-s clean prod:*",
"prod:js": "browserify -g unassertify -p common-shakeify -p bundle-collapser/plugin --debug renderer/index.js -o renderer/dist/bundle.js",
"prod:electron": "build",
"watch": "run-s clean && run-p watch:*",
"watch:js": "budo renderer/index.js:bundle.js -- --no-bundle-external",
"watch:electron": "electron main",
"test": "run-s test:*",
"test-skip:tape": "xvfb-maybe tape test/* | tap-format-spec",
"test:deps": "dependency-check ./package.json --entry renderer/index.js --no-dev --ignore-module electron",
"test:lint": "standard | snazzy",
"test:main": "tape main/lib/**/test.js | tap-format-spec",
"test:renderer": "tape renderer/**/test.js | tap-format-spec"
"test:renderer": "tape renderer/**/test.js | tap-format-spec",
"clean": "rimraf dist renderer/dist && mkdirp dist renderer/dist",
"clear": "electron scripts/clear.js"
},
"browserify": {
"transform": [
"envify",
"yo-yoify",
"electron-renderify"
]
}
}
2 changes: 1 addition & 1 deletion renderer/elements/player/artwork.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ var html = require('choo/html')
var Component = require('nanocomponent')
var fileUrlFromPath = require('file-url')
var path = require('path')
var defaultBG = path.resolve(__dirname, '../../../static/splash.jpg')
var defaultBG = path.resolve(window.__dirname, '../static/splash.jpg')
var compare = require('nanocomponent/compare')
var css = require('csjs-inject')

Expand Down
6 changes: 3 additions & 3 deletions renderer/elements/player/controls.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
var Component = require('nanocomponent')
var html = require('choo/html')
var button = require('../button')
var buttonStyles = require('../button/styles')
var bts = require('../button/styles')
var css = require('csjs-inject')

var styles = css`
Expand Down Expand Up @@ -54,7 +54,7 @@ class PlayerControls extends Component {
this.shuffling = shuffling

return html`
<div class=${styles.controls} ${buttonStyles.btnGroup}>
<div class=${styles.controls} ${bts.btnGroup}>
${button({
onclick: this.handlePrev,
iconName: 'entypo-controller-fast-backward'
Expand All @@ -70,7 +70,7 @@ class PlayerControls extends Component {
${button({
onclick: this.shuffleToggle,
iconName: 'entypo-shuffle',
className: shuffling ? buttonStyles.active : null
className: shuffling ? bts.active : null
})}
</div>
`
Expand Down
11 changes: 11 additions & 0 deletions renderer/index-dev.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<!doctype html>
<html>
<head>
<title>HyperAmp</title>
<link rel="stylesheet" href="css/index.css">
</head>
<body>
<main id="app"></main>
<script src="http://localhost:9966/bundle.js"></script>
</body>
</html>
2 changes: 1 addition & 1 deletion renderer/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@
</head>
<body>
<main id="app"></main>
<script>require('./index.js')</script>
<script src="./dist/bundle.js"></script>
</body>
</html>