attempt to add loader to playlist #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ill take a look. Sounds like maybe an _update issue. |
|
I made it work. For some reason having the root node types differ confused nanomnorph, resulting in a noop morph. |
bcomnes
approved these changes
Jul 5, 2017
bcomnes
approved these changes
Jul 5, 2017
|
|
||
| module.exports = function loader () { | ||
| return html` | ||
| <section class="${styles.loading}"> |
There was a problem hiding this comment.
Changing this from div to section, to match the other main root node, it works. Probably a nanomnorph bug.
|
Just read your comments above -- still don't really get why the root node types differing would matter. I'll try to figure it out tomorrow. |
|
It shouldn't matter, I don't think. I think its a bug in nanomnorph. I'm guessing its related to the fact these have the same ID but different root nodes + the child reordering algorithm that was just introduced. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bcomnes this PR shows the problem, which is still persisting for me. The cog spins when loading, but the playlist remains unchanged.
If you switch the line in
Playlist._renderfromto
you get
so I'm guessing this is an
_updatemethod issue?