Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fully restoring now playing state. #196

Closed
bcomnes opened this issue Jun 25, 2017 · 0 comments · Fixed by #204
Closed

Fix fully restoring now playing state. #196

bcomnes opened this issue Jun 25, 2017 · 0 comments · Fixed by #204
Labels
bug
Milestone
Winamp 2

Comments

@bcomnes
Copy link
Contributor

bcomnes commented Jun 25, 2017 •
edited
Loading

When you close and open the main window, the now playing meta data doesn't fully refresh into the view state.

screen shot 2017-06-25 at 3 43 36 pm
@bcomnes bcomnes added the bug label Jun 25, 2017
@bcomnes bcomnes added this to the Winamp 2 milestone Jun 25, 2017
bcomnes added a commit that referenced this issue Jun 30, 2017
@bcomnes
Properly restore now-playing when window is closed
26a0411 
Closes #196

It does introduce a bug though.  Because there is only one trackOrder
array, when we change the track order array, the metadata also get
updated, showing the wrong song info for whats playing.  It corrects on
the following queue, or if you restore whatever tracklist you had
before.

Fundamentally, we need to fix the data structure behind play queus and
the view state. We need to persist the active play state order, and only
activate a new play order state when a song is queued from a different
track order.

This issue is described more in #191
@bcomnes bcomnes mentioned this issue Jun 30, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
Winamp 2
Development

Successfully merging a pull request may close this issue.

Properly restore now-playing when window is closed hypermodules/hyperamp
1 participant
@bcomnes