Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perform validation to ensure that the three parameters, NumCounters, … #410

Merged
merged 4 commits into from
Oct 30, 2024
Merged

Perform validation to ensure that the three parameters, NumCounters, … #410

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9e363f7
Perform validation to ensure that the three parameters, NumCounters, …
Oct 28, 2024
d3fa633
Perform validation to ensure that the three parameters, NumCounters, …
Oct 29, 2024
35094d6
Merge branch 'strict_parameter_validation' of https://github.com/zhao…
Oct 29, 2024
89611c9
Merge branch 'dgraph-io:main' into strict_parameter_validation
zhaohaihang Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions cache.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,12 +166,12 @@ type Item[V any] struct {
// NewCache returns a new Cache instance and any configuration errors, if any.
func NewCache[K Key, V any](config *Config[K, V]) (*Cache[K, V], error) {
switch {
case config.NumCounters == 0:
zhaohaihang marked this conversation as resolved.
Show resolved Hide resolved
return nil, errors.New("NumCounters can't be zero")
case config.MaxCost == 0:
return nil, errors.New("MaxCost can't be zero")
case config.BufferItems == 0:
return nil, errors.New("BufferItems can't be zero")
case config.NumCounters <= 0:
return nil, errors.New("NumCounters can't be less than or equal to zero")
case config.MaxCost <= 0:
return nil, errors.New("MaxCost can't be less than or equal to zero")
case config.BufferItems <= 0:
return nil, errors.New("BufferItems can't be less than or equal to zero")
case config.TtlTickerDurationInSec == 0:
config.TtlTickerDurationInSec = bucketDurationSecs
}
Expand Down