Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for upsert block #88

Merged
merged 2 commits into from
Jun 26, 2019
Merged

Add support for upsert block #88

merged 2 commits into from
Jun 26, 2019

Conversation

animesh2049
Copy link
Contributor

@animesh2049 animesh2049 commented Jun 18, 2019 •
edited by manishrjain
Loading

This change is Reviewable

@animesh2049 animesh2049 requested review from gitlw, mangalaman93 and a team June 18, 2019 14:01
@animesh2049 animesh2049 self-assigned this Jun 18, 2019
@CLAassistant
Copy link

CLAassistant commented Jun 18, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@mangalaman93 mangalaman93 mentioned this pull request Jun 18, 2019
Merged
21 tasks
mangalaman93
mangalaman93 approved these changes Jun 20, 2019
View reviewed changes
Copy link
Member

@mangalaman93 mangalaman93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, LG! Get another approval before you merge it.

src/test/java/io/dgraph/UpsertBlockTest.java Outdated Show resolved Hide resolved
src/test/java/io/dgraph/UpsertBlockTest.java Outdated Show resolved Hide resolved
src/test/java/io/dgraph/UpsertBlockTest.java Outdated Show resolved Hide resolved
gitlw
gitlw approved these changes Jun 20, 2019
View reviewed changes
Copy link

@gitlw gitlw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 2 files reviewed, 3 unresolved discussions (waiting on @animesh2049 and @gitlw)

animesh2049
animesh2049 commented Jun 26, 2019
View reviewed changes
Copy link
Contributor Author

@animesh2049 animesh2049 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 3 unresolved discussions (waiting on @animesh2049 and @mangalaman93)

src/test/java/io/dgraph/UpsertBlockTest.java, line 12 at r1 (raw file):

Previously, mangalaman93 (Aman Mangal) wrote…

extra line here

Done.

src/test/java/io/dgraph/UpsertBlockTest.java, line 14 at r1 (raw file):

Previously, mangalaman93 (Aman Mangal) wrote…

empty line not needed

Done.

src/test/java/io/dgraph/UpsertBlockTest.java, line 18 at r1 (raw file):

Previously, mangalaman93 (Aman Mangal) wrote…

move the .setSchema in the next line

Done.

@animesh2049 animesh2049 merged commit 1e35cb2 into master Jun 26, 2019
@mangalaman93 mangalaman93 deleted the animesh2049/upsert branch June 26, 2019 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gitlw gitlw gitlw approved these changes

@mangalaman93 mangalaman93 mangalaman93 approved these changes

Assignees

@animesh2049 animesh2049

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@animesh2049 @CLAassistant @gitlw @mangalaman93