Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(DQL): unsupported ordering should raise an error #9173

Merged
merged 1 commit into from
Sep 19, 2024
Merged

fix(DQL): unsupported ordering should raise an error #9173

merged 1 commit into from
Sep 19, 2024

Conversation

shivaji-kharse
Copy link
Contributor

fixes #9145

@shivaji-kharse shivaji-kharse requested a review from a team as a code owner September 18, 2024 11:15
@github-actions github-actions bot added area/testing Testing related issues area/querylang Issues related to the query language specification and implementation. area/core internal mechanisms go Pull requests that update Go code area/enterprise Related to proprietary features area/enterprise/acl Related to Access Control Lists labels Sep 18, 2024
@harshil-goel harshil-goel enabled auto-merge (squash) September 19, 2024 08:44
@harshil-goel harshil-goel merged commit c2fef85 into main Sep 19, 2024
14 checks passed
@harshil-goel harshil-goel deleted the shiva/dql branch September 19, 2024 11:21
harshil-goel pushed a commit that referenced this pull request Oct 7, 2024
@shivaji-kharse @harshil-goel
fix(DQL): unsupported ordering should raise an error (#9173)
86573a6 
fixes #9145

Currently we allow multiple sorting but only with predicates. Vals() are not allowed for multiple sorting. We are now throwing an error instead of failing silently.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshil-goel harshil-goel harshil-goel approved these changes

Assignees
No one assigned
Labels
area/core internal mechanisms area/enterprise/acl Related to Access Control Lists area/enterprise Related to proprietary features area/querylang Issues related to the query language specification and implementation. area/testing Testing related issues go Pull requests that update Go code
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: DQL unsupported ordering is ignored and should raise an error
2 participants
@shivaji-kharse @harshil-goel