feat(vector): add vector to schema #9060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Harshil Goel seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
dgraph-bot
added
area/testing
harshil-goel
force-pushed
the
harshil-goel/vector-index-add
branch
from
2f14201 to
a3c812c
Compare
harshil-goel
force-pushed
the
harshil-goel/vector-index-add
branch
from
a3c812c to
32238a1
Compare
added 2 commits
March 28, 2024 09:45
harshil-goel
force-pushed
the
harshil-goel/vector-index-add
branch
from
735a883 to
9769f6e
Compare
mangalaman93
approved these changes
Apr 2, 2024
| } | ||
| if !it.Next() { | ||
| // Nothing to read. | ||
| return []string{}, it.Item().Errorf("Invalid ending.") | ||
| return tokenizers, vectorSpecs, it.Item().Errorf("Invalid ending.") |
There was a problem hiding this comment.
why can't we just return nil, nil, err
| @@ -42,7 +42,8 @@ func checkSchema(t *testing.T, h map[string]*pb.SchemaUpdate, expected []nameTyp | |||
| for _, nt := range expected { | |||
| typ, found := h[nt.name] | |||
| require.True(t, found, nt) | |||
| require.EqualValuesf(t, *nt.typ, *typ, "found in map: %+v\n expected: %+v", *typ, *nt.typ) | |||
| require.EqualValuesf(t, *nt.typ, *typ, "found in map: %+v\n expected: %+v", | |||
| resp, err := testutil.RetryQuery(dg, "schema {}") | ||
| require.NoError(t, err) | ||
|
|
||
| x.AssertTrue(strings.Contains(string(resp.Json), `{"predicate":"vectortest","type":"vfloat","tokenizer":["hnsw"]}`)) |
| @@ -0,0 +1,107 @@ | |||
| /* | |||
| * Copyright 2023 Hypermode, Inc. and Contributors | |||
There was a problem hiding this comment.
Do we want to keep it Hypermode?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.