Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade(go): update go version to 1.22 #9058

Merged
merged 5 commits into from
Mar 23, 2024
Merged

upgrade(go): update go version to 1.22 #9058

merged 5 commits into from
Mar 23, 2024

Conversation

harshil-goel
Copy link
Contributor

@harshil-goel harshil-goel commented Mar 22, 2024 •
edited by mangalaman93
Loading

fixes tests to use docker compose instead of docker-compose

@harshil-goel harshil-goel requested a review from a team as a code owner March 22, 2024 17:48
@CLAassistant
Copy link

CLAassistant commented Mar 22, 2024 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ mangalaman93
❌ Harshil Goel

Harshil Goel seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@dgraph-bot dgraph-bot added area/testing Testing related issues area/graphql Issues related to GraphQL support on Dgraph. area/core internal mechanisms go Pull requests that update Go code labels Mar 22, 2024
mangalaman93
mangalaman93 reviewed Mar 22, 2024
View reviewed changes
graphql/schema/rules.go
@@ -32,8 +32,8 @@ import (
)

const (
baseRules = 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add an explanation here

@mangalaman93 mangalaman93 mentioned this pull request Mar 22, 2024
Closed
@mangalaman93 mangalaman93 changed the title Update go version to 1.22 build(go): update go version to 1.22 Mar 22, 2024
@mangalaman93 mangalaman93 changed the title build(go): update go version to 1.22 upgrade(go): update go version to 1.22 Mar 23, 2024
@mangalaman93 mangalaman93 merged commit 4072134 into main Mar 23, 2024
9 of 11 checks passed
@mangalaman93 mangalaman93 deleted the version branch March 23, 2024 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mangalaman93 mangalaman93 mangalaman93 approved these changes

Assignees
No one assigned
Labels
area/core internal mechanisms area/graphql Issues related to GraphQL support on Dgraph. area/testing Testing related issues go Pull requests that update Go code
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@harshil-goel @CLAassistant @mangalaman93 @dgraph-bot