fix(upgrade): look for version string in logs bottom up #8926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mangalaman93
requested review from
meghalims,
sanjayk-github-dev,
harshil-goel,
all-seeing-code,
billprovince and
joshua-goldstein
as code owners
For in place upgrade, the container remains the same and has the version string twice, one for the old container and one for the new container. We want the version string in the logs for the new container. Hence, we look for the string in the logs bottom up by using strings.LastIndex instead of strings.Index.
mangalaman93
force-pushed
the
aman/upgrade
branch
from
1ded2bf to
1202be2
Compare
harshil-goel
previously approved these changes
Aug 1, 2023
all-seeing-code
previously approved these changes
Aug 2, 2023
all-seeing-code
approved these changes
Aug 2, 2023
harshil-goel
approved these changes
Aug 2, 2023
jbhamra1
pushed a commit
that referenced
this pull request
Aug 17, 2023
For in place upgrade, the container remains the same and the logs have the version string twice, one for the old container and one for the new container. We want the version string in the logs for the new container. Hence, we look for the string in the logs bottom up by using strings.LastIndex instead of strings.Index.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For in place upgrade, the container remains the same and the logs have the version string twice, one for the old container and one for the new container. We want the version string in the logs for the new container. Hence, we look for the string in the logs bottom up by using strings.LastIndex instead of strings.Index.