fix failing oss build #8832
Merged
fix failing oss build #8832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mangalaman93
requested review from
akon-dey,
skrdgraph and
darkn3rd
as code owners
dgraph-bot
added
area/enterprise
mangalaman93
requested review from
meghalims,
matthewmcneely and
billprovince
as code owners
joshua-goldstein
suggested changes
May 19, 2023
|
Still fails |
joshua-goldstein
approved these changes
May 22, 2023
Is it failing locally for you? It works locally for me on this branch: |
|
I think he just means that the upgrade tests were failing. The test passes now. |
all-seeing-code
approved these changes
May 22, 2023
mangalaman93
pushed a commit
that referenced
this pull request
May 31, 2023
## Problem Previous commits broke OSS build. Since we didn't have a test for this, it was undetected by CI. ## Solution Add a CI job to verify that we can make the dgraph OSS build, and run all dgraph OSS unit tests. We do this in a separate workflow because this does not require a separate self-hosted runner (we can use github hosted runners for this job). See also: #8832
dgraph-bot
pushed a commit
that referenced
this pull request
Jul 7, 2023
dgraph-bot
pushed a commit
that referenced
this pull request
Jul 7, 2023
## Problem Previous commits broke OSS build. Since we didn't have a test for this, it was undetected by CI. ## Solution Add a CI job to verify that we can make the dgraph OSS build, and run all dgraph OSS unit tests. We do this in a separate workflow because this does not require a separate self-hosted runner (we can use github hosted runners for this job). See also: #8832
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8831