Fix wal replay issue during rollup #8774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshil-goel
requested review from
akon-dey,
skrdgraph,
darkn3rd,
meghalims,
matthewmcneely and
billprovince
as code owners
dgraph-bot
added
area/bulk-loader
mangalaman93
previously approved these changes
Mar 30, 2023
all-seeing-code
previously approved these changes
Mar 30, 2023
mangalaman93
dismissed stale reviews from all-seeing-code and themself
via
253c709
mangalaman93
force-pushed
the
harshil/rollup_ts_fix
branch
2 times, most recently
from
253c709 to
76b6225
Compare
added 6 commits
April 10, 2023 16:34
Rollups can cause issues during wal replay. This diff fixes the issue by issuing incremental rollup at a new timestamp where the rollup would be written. We wait until the ts-1 time to read the data, and then do the rollup at timestamp. FIXES https://dgraph.atlassian.net/browse/DGRAPHCORE-92
harshil-goel
force-pushed
the
harshil/rollup_ts_fix
branch
from
b13ee36 to
8c376ea
Compare
mangalaman93
approved these changes
Apr 10, 2023
all-seeing-code
approved these changes
Apr 10, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have confirmation that rollups can cause issues during wal replay. This diff fixes the issue by issuing incremental rollup a new timestamp where the rollup would be written. We wait until the timestamp - 1 time to read the data, and then do the rollup at timestamp.
Performance implications:
Live loader before:
Number of TXs run : 21240
Number of N-Quads processed : 21239870
Time spent : 10m26.664095134s
N-Quads processed per second : 33929
Live Loader after the changes:
Number of TXs run : 21240
Number of N-Quads processed : 21239870
Time spent : 10m23.564645632s
N-Quads processed per second : 34312
Negligible different in time taken to upload 21 million dataset.