Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup tests to reduce the scope of err var #8771

Merged
merged 1 commit into from
Mar 30, 2023
Merged

cleanup tests to reduce the scope of err var #8771

merged 1 commit into from
Mar 30, 2023

Conversation

mangalaman93
Copy link
Member

No description provided.

@dgraph-bot dgraph-bot added area/core internal mechanisms area/enterprise Related to proprietary features area/enterprise/acl Related to Access Control Lists area/graphql Issues related to GraphQL support on Dgraph. area/integrations Related to integrations with other projects. area/testing Testing related issues go Pull requests that update Go code labels Mar 28, 2023
@mangalaman93 mangalaman93 force-pushed the aman/cleanup branch 2 times, most recently from 2c7673b to 3845883 Compare March 28, 2023 06:38
@mangalaman93 mangalaman93 changed the title cleanup tests to use require.NoError cleanup tests to reduce the scope of err var Mar 28, 2023
harshil-goel
harshil-goel previously approved these changes Mar 28, 2023
View reviewed changes
@mangalaman93 mangalaman93 merged commit 2682eff into main Mar 30, 2023
@mangalaman93 mangalaman93 deleted the aman/cleanup branch March 30, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshil-goel harshil-goel harshil-goel approved these changes

@all-seeing-code all-seeing-code all-seeing-code approved these changes

@akon-dey akon-dey Awaiting requested review from akon-dey

@MichelDiz MichelDiz Awaiting requested review from MichelDiz

@matthewmcneely matthewmcneely Awaiting requested review from matthewmcneely

@skrdgraph skrdgraph Awaiting requested review from skrdgraph

@darkn3rd darkn3rd Awaiting requested review from darkn3rd

@meghalims meghalims Awaiting requested review from meghalims

@billprovince billprovince Awaiting requested review from billprovince

Assignees
No one assigned
Labels
area/core internal mechanisms area/enterprise/acl Related to Access Control Lists area/enterprise Related to proprietary features area/graphql Issues related to GraphQL support on Dgraph. area/integrations Related to integrations with other projects. area/testing Testing related issues go Pull requests that update Go code
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mangalaman93 @all-seeing-code @harshil-goel @dgraph-bot