Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(tests): add upgrade tests in query package #8750

Merged
merged 1 commit into from
Mar 30, 2023
Merged

chore(tests): add upgrade tests in query package #8750

merged 1 commit into from
Mar 30, 2023

Conversation

mangalaman93
Copy link
Member

@mangalaman93 mangalaman93 commented Mar 13, 2023 •
edited
Loading

No description provided.

@dgraph-bot dgraph-bot added area/core internal mechanisms area/testing Testing related issues go Pull requests that update Go code labels Mar 13, 2023
@mangalaman93 mangalaman93 marked this pull request as ready for review March 14, 2023 19:00
@mangalaman93 mangalaman93 force-pushed the aman/upgrade branch 2 times, most recently from d65d5d9 to 62e57c8 Compare March 17, 2023 23:02
@mangalaman93 mangalaman93 changed the base branch from main to aman/dtest March 17, 2023 23:02
@mangalaman93 mangalaman93 force-pushed the aman/dtest branch 2 times, most recently from becfd80 to da4061a Compare March 18, 2023 17:44
Base automatically changed from aman/dtest to main March 20, 2023 04:53
@mangalaman93 mangalaman93 force-pushed the aman/upgrade branch 7 times, most recently from 26ef75e to e5985ef Compare March 23, 2023 05:51
joshua-goldstein
joshua-goldstein reviewed Mar 27, 2023
View reviewed changes
query/upgrade_test.go Show resolved Hide resolved
query/upgrade_test.go Show resolved Hide resolved
query/rdf_result_test.go Show resolved Hide resolved
all-seeing-code
all-seeing-code approved these changes Mar 28, 2023
View reviewed changes
query/common_test.go Show resolved Hide resolved
@mangalaman93 mangalaman93 merged commit d4674b8 into main Mar 30, 2023
@mangalaman93 mangalaman93 deleted the aman/upgrade branch March 30, 2023 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshua-goldstein joshua-goldstein joshua-goldstein left review comments

@harshil-goel harshil-goel harshil-goel approved these changes

@all-seeing-code all-seeing-code all-seeing-code approved these changes

@akon-dey akon-dey Awaiting requested review from akon-dey

@skrdgraph skrdgraph Awaiting requested review from skrdgraph

@darkn3rd darkn3rd Awaiting requested review from darkn3rd

@meghalims meghalims Awaiting requested review from meghalims

@matthewmcneely matthewmcneely Awaiting requested review from matthewmcneely

@billprovince billprovince Awaiting requested review from billprovince

Assignees
No one assigned
Labels
area/core internal mechanisms area/testing Testing related issues go Pull requests that update Go code
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mangalaman93 @all-seeing-code @harshil-goel @joshua-goldstein @dgraph-bot