recreate the context variable for parallel test #8748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mangalaman93
requested review from
akon-dey,
skrdgraph and
darkn3rd
as code owners
dgraph-bot
added
area/enterprise
mangalaman93
force-pushed
the
aman/aclfix
branch
from
0f5ca85 to
82ce691
Compare
mangalaman93
requested review from
MichelDiz,
matthewmcneely,
meghalims and
billprovince
as code owners
Also, use require.NoError instead of require.Nil for ensuring that error is nil. This prints better when err is not nil.
mangalaman93
force-pushed
the
aman/aclfix
branch
from
82ce691 to
677c35b
Compare
harshil-goel
approved these changes
Mar 13, 2023
|
@mangalaman93 The PR is fine, just wondering how do you know that this should fix the flakyness? PR looks no-op to me.
|
all-seeing-code
approved these changes
Mar 13, 2023
mangalaman93
commented
Mar 13, 2023
| @@ -1892,7 +1892,7 @@ func TestNewACLPredicates(t *testing.T) { | |||
| tc := tc // capture range variable | |||
| t.Run(tc.description, func(t *testing.T) { | |||
| t.Parallel() | |||
| ctx, cancel = context.WithTimeout(context.Background(), 100*time.Second) | |||
| ctx, cancel := context.WithTimeout(context.Background(), 100*time.Second) | |||
There was a problem hiding this comment.
@anurags92 this is the change that could fix the flakiness. The rest of the change is so that we see the errors better in the logs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, use require.NoError instead of require.Nil for ensuring that error is nil. This prints better when err is not nil.