chore(tests): run tests in query package against dgraph cloud #8726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mangalaman93
requested review from
akon-dey,
skrdgraph,
darkn3rd,
meghalims,
matthewmcneely and
billprovince
as code owners
mangalaman93
force-pushed
the
aman/upgrade
branch
from
3242e2b to
f17bcc9
Compare
all-seeing-code
previously approved these changes
Mar 9, 2023
mangalaman93
force-pushed
the
aman/cloud
branch
from
465e0d4 to
6db5113
Compare
mangalaman93
force-pushed
the
aman/cloud
branch
from
6db5113 to
9d19ae0
Compare
| ) | ||
|
|
||
| func TestMain(m *testing.M) { | ||
| c, err := dgraphtest.NewDCloudCluster() |
There was a problem hiding this comment.
Maybe add a comment that it needs TEST_DGRAPH_CLOUD_CLUSTER_URL and TEST_DGRAPH_CLOUD_CLUSTER_TOKEN in env. I understand they'd see the error, but keeping a comment will be helpful here as well.
There was a problem hiding this comment.
I will create it in the next PR. There are other things that I need to add too.
| @@ -350,13 +349,13 @@ age2 : int @index(int) . | |||
|
|
|||
| func populateCluster() { | |||
| if err := client.Alter(context.Background(), &api.Operation{DropAll: true}); err != nil { | |||
| panic(fmt.Sprintf("Could not perform DropAll op. Got error %v", err.Error())) | |||
| panic(err) | |||
There was a problem hiding this comment.
Any reason to remove the wrapping?
There was a problem hiding this comment.
It's not needed. Just panic(error) will give you enough information to figure out what happened.
mangalaman93
force-pushed
the
aman/cloud
branch
from
9d19ae0 to
5d52be7
Compare
shivaji-kharse
previously approved these changes
Mar 13, 2023
all-seeing-code
previously approved these changes
Mar 13, 2023
mangalaman93
dismissed stale reviews from all-seeing-code and shivaji-kharse
via
5e88f24
mangalaman93
force-pushed
the
aman/cloud
branch
from
5d52be7 to
5e88f24
Compare
shivaji-kharse
approved these changes
Mar 13, 2023
all-seeing-code
approved these changes
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.