fix: check index for next word and replace global index with local one #8719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hezhizhen
requested review from
akon-dey,
MichelDiz,
matthewmcneely,
skrdgraph,
darkn3rd,
meghalims and
billprovince
as code owners
dgraph-bot
added
area/bulk-loader
mangalaman93
requested changes
Mar 3, 2023
|
@mangalaman93 I need some help to pass the failed tests. |
|
rerunning the failed test. It is failing due to a known issue, we are looking into it. |
mangalaman93
approved these changes
Mar 4, 2023
@mangalaman93 How can I re-run failed tests? |
MichelDiz
approved these changes
Mar 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
nextWord()used a global index and simply got the word from the list based on the index without checking if it's in the range.Solution
Pass the index as an argument to the function and let the callers maintain the index themselves (increase it here), and check if the index is valid.
I also fixed some typo and comments by the way.