chore(linter): add unconvert linter and address related issues

[hezhizhen]

Problem

Solution

[CLAassistant]

All committers have signed the CLA.

[mangalaman93]

@hezhizhen Thanks for PR, LGTM. Will merge it when the test passes.

[hezhizhen]

labeler is failed. @mangalaman93

[hezhizhen]

@mangalaman93 Can you re-run failed tests?

[skrdgraph]

@hezhizhen we have an open issue for the code-coverage failure here. This should ideally not be a blocker for your PR, as the test part of the pipeline ran fine. The issue has more details around why it is failing (it's a perceived failure).

Regarding the labeler, I believe it's a similar issue. @MichelDiz can you cross check here?

From what I can say, the PR is in a good shape.

[skrdgraph]

@hezhizhen we have made a fix to our pipelines to address the above issue I had stated. The fixes primarily went in 2 PRs #8717 & #8716. Could you pull the latest main into your branch? This should give you a GREEN tick on all the tests.

Another request, I raised a PR to address this issue - #8705. I don't intend to merge mine. Would it be possible for you to port missing changes from mine into yours? TIA!

[hezhizhen]

@hezhizhen we have made a fix to our pipelines to address the above issue I had stated. The fixes primarily went in 2 PRs #8717 & #8716. Could you pull the latest main into your branch? This should give you a GREEN tick on all the tests.

Another request, I raised a PR to address this issue - #8705. I don't intend to merge mine. Would it be possible for you to port missing changes from mine into yours? TIA!

Okay, I'll rebase main and add the missing changes from your PR. Thanks.

[hezhizhen]

@skrdgraph I rebased main and checked every change you made in #8705 . I suppose the missing change is nolint:unused in common.go, and I commented there why this is not necessary. Correct me if I'm wrong.

[skrdgraph]

@hezhizhen thanks for taking time to do this - appreciate your help. I have validated this on my machine as well.

Sudhishs-MacBook-Pro-Work:tmp sudhishkr$ git clone https://github.com/hezhizhen/dgraph.git
Cloning into 'dgraph'...
remote: Enumerating objects: 70636, done.
remote: Counting objects: 100% (209/209), done.
remote: Compressing objects: 100% (181/181), done.
remote: Total 70636 (delta 56), reused 151 (delta 24), pack-reused 70427
Receiving objects: 100% (70636/70636), 364.04 MiB | 17.84 MiB/s, done.
Resolving deltas: 100% (48207/48207), done.
Sudhishs-MacBook-Pro-Work:tmp sudhishkr$ cd dgraph/
Sudhishs-MacBook-Pro-Work:dgraph sudhishkr$ golangci-lint run --max-same-issues=100
Sudhishs-MacBook-Pro-Work:dgraph sudhishkr$ echo $?
0
Sudhishs-MacBook-Pro-Work:dgraph sudhishkr$ 

PS: if you are interested in contributing further - we do maintain a small todo list OR you can l

ook through reported issues on GH as well.

[hezhizhen]

@hezhizhen thanks for taking time to do this - appreciate your help. I have validated this on my machine as well.

Sudhishs-MacBook-Pro-Work:tmp sudhishkr$ git clone https://github.com/hezhizhen/dgraph.git
Cloning into 'dgraph'...
remote: Enumerating objects: 70636, done.
remote: Counting objects: 100% (209/209), done.
remote: Compressing objects: 100% (181/181), done.
remote: Total 70636 (delta 56), reused 151 (delta 24), pack-reused 70427
Receiving objects: 100% (70636/70636), 364.04 MiB | 17.84 MiB/s, done.
Resolving deltas: 100% (48207/48207), done.
Sudhishs-MacBook-Pro-Work:tmp sudhishkr$ cd dgraph/
Sudhishs-MacBook-Pro-Work:dgraph sudhishkr$ golangci-lint run --max-same-issues=100
Sudhishs-MacBook-Pro-Work:dgraph sudhishkr$ echo $?
0
Sudhishs-MacBook-Pro-Work:dgraph sudhishkr$ 

PS: if you are interested in contributing further - we do maintain a small todo list OR you can l ook through reported issues on GH as well.

Oh, I didn't notice it. Thanks for reminding me of that.

I'll take a look at those items and try to solve some if I can.