-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(linter): fix some of the warnings from gas linter #8664
Conversation
4d9dce8
to
9800210
Compare
c93bbb0
to
6f4b264
Compare
@mangalaman93 Can you add what's gas linter (probably a link as well)? |
9800210
to
77b329d
Compare
6f4b264
to
00cf4c3
Compare
d7484b1
to
a662e0d
Compare
00cf4c3
to
3bc53e8
Compare
a662e0d
to
4b08ae4
Compare
01fbbf5
to
3bc53e8
Compare
a187cdb
to
af3e142
Compare
@anurags92 this explains all linters https://golangci-lint.run/usage/linters/ (I recommend spending about 15mins doing a high level reading) & compare with our Also this was something I had bookmarked https://github.com/golangci/awesome-go-linters (may have deprecated linters). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The coverage upload failed, there was probably a glitch in network or an issue on coveralls. The test will need a re-trigger.
I also think this will be interesting to observe our logs on v23.
af3e142
to
3ab751d
Compare
Thanks Sudhish, yeah, will need to keep an eye out. I didn't see anything interesting during my testing locally on the laptop. |
3ab751d
to
981e99d
Compare
this is the linter https://github.com/securego/gosec