refactor(metrics) record function is not needed as both calls are always made sequentially #8650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cscetbon
requested review from
akon-dey,
skrdgraph,
darkn3rd,
meghalims,
matthewmcneely and
billprovince
as code owners
|
Thanks @cscetbon for the PR. I have enabled CI run for this PR, if all the test passes, we could merge this. |
Unfortunately the same thing has been preventing PRs from being merged for the last 2 weeks because of an issue with sending coverage results which had nothing to do with those PRs |
|
We are looking into and we should either find a way around or fix it head on. I will keep you posted. Thanks |
|
We are still looking at this issue, give us another few days to figure it out. |
mangalaman93
approved these changes
Feb 17, 2023
harshil-goel
approved these changes
Feb 17, 2023
|
@cscetbon Thanks for your contribution :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
MonitorCacheHealth uses an internal function to record metrics. 2 calls are done always sequentially to this method. It always handles a case where the wrong type is used but that would never happen.
Solution
Get rid of that function and inline both calls sequentially