Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added automated test to test multitenant --limit flag #8646

Merged
merged 6 commits into from
Feb 14, 2023
Merged

Added automated test to test multitenant --limit flag #8646

merged 6 commits into from
Feb 14, 2023

Conversation

shivaji-kharse
Copy link
Contributor

In this test we are testing the rate limit in multitenant cluster.

  • We created a multi-tenant cluster with a --limit flag set with the uid lease limit of 50 and tried to lease more uids than the lease limit and checks the error message’s

@github-actions github-actions bot added the area/testing Testing related issues label Feb 2, 2023
@shivaji-kharse shivaji-kharse force-pushed the shiva/multitenant-limit-test branch from 4a5e1a5 to 48c771e Compare February 2, 2023 10:50
@coveralls
Copy link

coveralls commented Feb 2, 2023 •
edited
Loading

Coverage Status

Coverage: 67.08% (+0.2%) from 66.887% when pulling 835f87a on shiva/multitenant-limit-test into e2990d1 on main.

@shivaji-kharse shivaji-kharse force-pushed the shiva/multitenant-limit-test branch from 48c771e to 2975ead Compare February 2, 2023 13:14
@shivaji-kharse shivaji-kharse force-pushed the shiva/multitenant-limit-test branch 3 times, most recently from bc54420 to eb860f2 Compare February 9, 2023 14:49
mangalaman93
mangalaman93 requested changes Feb 10, 2023
View reviewed changes
Copy link
Member

@mangalaman93 mangalaman93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changes, looks simple enough!

systest/multi-tenancy/docker-compose.yml Show resolved Hide resolved
testutil/multi_tenancy.go Show resolved Hide resolved
systest/multi-tenancy/basic_test.go Outdated Show resolved Hide resolved
systest/multi-tenancy/basic_test.go Outdated Show resolved Hide resolved
@shivaji-kharse shivaji-kharse force-pushed the shiva/multitenant-limit-test branch from eb860f2 to be39297 Compare February 10, 2023 05:13
mangalaman93
mangalaman93 previously approved these changes Feb 10, 2023
View reviewed changes
@mangalaman93 mangalaman93 self-requested a review February 14, 2023 04:57
@mangalaman93 mangalaman93 merged commit bbdea33 into main Feb 14, 2023
@mangalaman93 mangalaman93 deleted the shiva/multitenant-limit-test branch February 14, 2023 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@all-seeing-code all-seeing-code all-seeing-code approved these changes

@mangalaman93 mangalaman93 mangalaman93 approved these changes

@matthewmcneely matthewmcneely matthewmcneely approved these changes

@akon-dey akon-dey Awaiting requested review from akon-dey

@skrdgraph skrdgraph Awaiting requested review from skrdgraph

@darkn3rd darkn3rd Awaiting requested review from darkn3rd

@meghalims meghalims Awaiting requested review from meghalims

@billprovince billprovince Awaiting requested review from billprovince

Assignees
No one assigned
Labels
area/testing Testing related issues
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shivaji-kharse @coveralls @matthewmcneely @mangalaman93 @all-seeing-code